Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx #779

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update Sphinx #779

merged 1 commit into from
Jan 2, 2025

Conversation

kprosise
Copy link
Contributor

Sphinx and its depends have have been updated to more recent versions. For Sphinx this brings a number of improvements, and brings it from v5.3 to v8.1.

It should be noted that this will require python 3.11 or greater. Running linkcheck locally resulted in a number of ssl cert errors. These errors are a new feature. However it does not appear as if it can be disabled. It is also possible that the errors resulted from a local issue.

QA Steps: Ran linkcheck (see above note), checked rendered HTML, checked that PDF built as expected

No related tasks/issues, regular maintenance task

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)

Overview

Sphinx 5 -> 8. A large number of changes and fixes have been introduced.

The required Python version has changed from 3.9 to 3.11

Addressed some of the linkcheck issues found.

It is possible that there will be CI build issues to work out.

Checklist

  • Avoid changing any header associated with a link/reference.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Sphinx and its depends have have been updated to more recent versions.
For Sphinx this brings a number of improvements, and brings it from v5.3
to v8.1.

It should be noted that this will require python 3.11 or greater.
Running linkcheck locally resulted in a number of ssl cert errors. These
errors are a new feature. However it does not appear as if it can be
disabled. It is also possible that the errors resulted from a local
issue.

QA Steps: Ran linkcheck (see above note), checked rendered HTML, checked
that PDF built as _expected_

No related tasks/issues, regular maintenance task

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise requested review from doanac, angolini, vanmaegima and a team December 26, 2024 16:46
@kprosise
Copy link
Contributor Author

Linkcheck failure expected

Copy link
Collaborator

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kprosise
Copy link
Contributor Author

kprosise commented Jan 2, 2025

I noticed the comment with the HTML link wasn't added. The PR docs are at https://ci.foundries.io/projects/fio-docs/builds/2808/docs/artifacts/html/index.html

@kprosise kprosise merged commit 03c61c7 into foundriesio:main Jan 2, 2025
1 of 3 checks passed
@kprosise kprosise deleted the update-sphinx branch January 2, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants